-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added defaults to PeoplePicker doc #159
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #159 +/- ##
=======================================
Coverage 80.63% 80.63%
=======================================
Files 10 10
Lines 346 346
Branches 71 78 +7
=======================================
Hits 279 279
Misses 44 44
Partials 23 23 Continue to review full report at Codecov.
|
There is a new property Could you please include the default value of it to your patch? Thanks, |
Done, but it sort of seems like the doc change should be in your PR so they live together. M. |
It was landed in the dev branch |
Thanks @sympmarc this makes things a lot easier indeed. I had to manually do the merge, but it's in. |
@estruyf If you think adding the defaults the way I did for the PeoplePicker is useful, let me know and I'll try to puzzle out some of the others. Sorry about the merge difficulties. It was probably because I added the additional default above after the fact. |
What's in this Pull Request?
Example for displaying defaults for using the PeoplePicker control - issue #158