Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PeoplePicker - Added REST API filter and nometadata header to reduce payload #139

Merged
merged 1 commit into from
Oct 15, 2018
Merged

PeoplePicker - Added REST API filter and nometadata header to reduce payload #139

merged 1 commit into from
Oct 15, 2018

Conversation

gautamdsheth
Copy link
Contributor

Q A
Bug fix? N
New feature? Y
New sample? N
Related issues? NA

What's in this Pull Request?

  1. Added a filter to the people picker REST API endpoint to filter out principal types specified in the webpart.

  2. Added filter to the endpoint to determine if IsHiddenInUI is set to true.

  3. Added nometadata header to reduce payload size.

@codecov-io
Copy link

Codecov Report

Merging #139 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #139   +/-   ##
=======================================
  Coverage   80.63%   80.63%           
=======================================
  Files          10       10           
  Lines         346      346           
  Branches       78       71    -7     
=======================================
  Hits          279      279           
  Misses         44       44           
  Partials       23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9eb35e...4abed31. Read the comment docs.

@estruyf estruyf merged commit 4abed31 into pnp:dev Oct 15, 2018
@estruyf
Copy link
Member

estruyf commented Oct 15, 2018

Thanks @gautamdsheth, just merged your changes to the DEV branch and will be available in version 1.10.0.

@estruyf estruyf added this to the 1.10.0 milestone Oct 15, 2018
@gautamdsheth gautamdsheth deleted the peoplePickerRestFilter branch October 16, 2018 05:54
@estruyf estruyf mentioned this pull request Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants