Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming consistency - media_album_artist_template #25

Open
Seperis opened this issue Jan 17, 2021 · 1 comment
Open

Naming consistency - media_album_artist_template #25

Seperis opened this issue Jan 17, 2021 · 1 comment

Comments

@Seperis
Copy link
Contributor

Seperis commented Jan 17, 2021

This is super minor and basically a matter of naming consistency

To keep consistency, you might change "media_album_artist_template" to "album_artist_template" for consistency in your template. Both 'artist' and "album" don't have 'media_' in front, which I assume is because they're music; "media_album_artist_template" also is music-exclusive so as a visual reference to what content-type this template is associated with. I noticed--and appreciate--that tv-related uses the prefix 'media_' (season, episode, series name). It's not a big deal, and I verified changing the name doesn't make any real difference other than when I'm reading the code. I can make the change and do the pull if you want, but like I said, it's really just a code consistency thing.

This template is working gangbusters for my Combined Media Player, so thank you. This has been bar none the most useful and fun single custom_component I've played with.

@Sennevds
Copy link
Owner

Hi really sorry for the late reply. Could you make a pr? I don't know when I have time to set everything up again after several formats of my pc and quiet busy personal life at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants