Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove second react dependency #728

Closed
humphd opened this issue Feb 16, 2020 · 5 comments · Fixed by #781
Closed

Remove second react dependency #728

humphd opened this issue Feb 16, 2020 · 5 comments · Fixed by #781
Assignees
Labels
5 min fix Fixable in 5 minutes or less type: bug Something isn't working

Comments

@humphd
Copy link
Contributor

humphd commented Feb 16, 2020

We have react defined in two different places:

  1. https://github.com/Seneca-CDOT/telescope/blob/master/src/frontend/package.json#L18
  2. https://github.com/Seneca-CDOT/telescope/blob/master/package.json#L99

The first one (in src/frontend/package.json) is correct, and the other one (package.json) needs to get removed.

@humphd humphd added type: bug Something isn't working good first issue Good for newcomers 5 min fix Fixable in 5 minutes or less labels Feb 16, 2020
@humphd
Copy link
Contributor Author

humphd commented Feb 16, 2020

Maybe I'm wrong. Did we do this for detecting the react version? cc @agarcia-caicedo, @miggs125

One way or the other, let's only include this once so we don't have version conflicts later.

@humphd humphd removed the good first issue Good for newcomers label Feb 16, 2020
@agarcia-caicedo
Copy link
Contributor

The one in the package.json was for detecting react

@miggs125
Copy link
Contributor

Leaving it in package.json means that every time we do npm i we will download react twice. Once in the frontend and once in the root of the project. Is there a way to detect react without downloading it twice? Perhaps we can link to the frontend package.json from the root of the project?

@humphd
Copy link
Contributor Author

humphd commented Feb 20, 2020

Let's find a way to link to the one in frontend, yes.

@agarcia-caicedo
Copy link
Contributor

The one in the package.json was for detecting react

I was wrong, detecting react happens in the eslint config file, not in package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 min fix Fixable in 5 minutes or less type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants