Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically update Satellite dependency versions #2959

Closed
RC-Lee opened this issue Feb 17, 2022 · 5 comments · Fixed by #3050
Closed

Automatically update Satellite dependency versions #2959

RC-Lee opened this issue Feb 17, 2022 · 5 comments · Fixed by #3050
Assignees
Labels
type: enhancement New feature or request
Milestone

Comments

@RC-Lee
Copy link
Contributor

RC-Lee commented Feb 17, 2022

What would you like to be added:
Find a way to automatically update Satellite dependency versions

Why would you like this to be added:
Following the conversations through #2934 , we have to manually get the Satellite updates.
Let's see if we have a way to automate this before Satellite is moved into Telescope in #2677

@RC-Lee RC-Lee added the type: enhancement New feature or request label Feb 17, 2022
@menghif menghif added this to the 2.8 Release milestone Feb 17, 2022
@humphd
Copy link
Contributor

humphd commented Feb 17, 2022

Talking with @joelazwar on Slack today, one thing that does work is:

pnpm update -r --latest @senecacdot/satellite

This will rewrite all the package.json files throughout the monorepo, and also update the lock file.

@joelazwar
Copy link
Contributor

joelazwar commented Feb 17, 2022

been googling for a workaround with no luck, i guess this is our best option so far. We could document this step in the Satellite Shipping guide docs TBD. Want to wait for @rclee91 before we run that command and push, she might have more knowledge on this topic

@RC-Lee
Copy link
Contributor Author

RC-Lee commented Feb 17, 2022

No, I don't know this command at all, I wish I did.
Since we're manually doing it anyways, might as well do it how it manually works for us.

@RC-Lee
Copy link
Contributor Author

RC-Lee commented Feb 17, 2022

I'm guessing from this line that we get sometimes after running pnpm install

Lockfile is up-to-date, resolution step is skipped

The lockfile will only update with pnpm install if something is changed in the various package.json

@humphd
Copy link
Contributor

humphd commented Feb 17, 2022

Correct, which is why pnpm update ... makes it happen, since it updates the package.json files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants