-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UI to deal with GitHub rate limiting in Dashboard #2591
Labels
area: dashboard
Related to Telescope's dashboard (the page that has stats)
type: enhancement
New feature or request
Comments
Is this for the dashboard? |
No, for the React front-end with GitHub info in the sidebar of a post. We can manage this on the server side for the Dashboard with caching in Redis. |
TDDR
changed the title
Add UI to deal with GitHub rate limiting in front-end
Add UI to deal with GitHub rate limiting in Dashboard
Jan 20, 2022
TDDR
added
area: dashboard
Related to Telescope's dashboard (the page that has stats)
and removed
area: front-end
labels
Jan 20, 2022
@tcvan0707 if you cna put some details about your struggle. People will be able to help out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: dashboard
Related to Telescope's dashboard (the page that has stats)
type: enhancement
New feature or request
We've got a bunch of fancy new GitHub components for our posts, each of which make various calls to the GitHub API from the browser. GitHub's API is rate limited, and for unauthenticated requests:
I haven't hit this yet, but it's just a matter of time. As we scroll through posts, eventually we'll hit the 60/hour limit and the API call will fail. When that happens, our GitHub components need to render something useful to the user.
We should also consider switching to use GitHub's official JS client, which has built-in code for handling throttling and retrying rate-limited calls.
cc @Kevan-Y who hit this in the backend. NOTE: https://github.com/octokit/octokit.js works in browser and node, so we could use this in the backend too, when talking to the GitHub API.
The text was updated successfully, but these errors were encountered: