Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve how we show GitHub Repos for a post #2371

Closed
humphd opened this issue Oct 20, 2021 · 2 comments · Fixed by #2397
Closed

Improve how we show GitHub Repos for a post #2371

humphd opened this issue Oct 20, 2021 · 2 comments · Fixed by #2397
Labels
area: design Issues needing design or assets area: front-end type: enhancement New feature or request

Comments

@humphd
Copy link
Contributor

humphd commented Oct 20, 2021

In #2367 we are adding GitHub info to a post. For the repos, we decided to try only showing the repo name vs. the username/org-name + repo, due to length: telescope instead of Seneca-CDOT/telescope. However, this leads to a bit of a bug where the same repo name with different user/org shows up twice.

We should see if we can improve this situation. We only really need the username when the name of the repo repeats, for example:

image

@humphd humphd added type: enhancement New feature or request area: front-end area: design Issues needing design or assets labels Oct 20, 2021
@Andrewnt219
Copy link
Contributor

Andrewnt219 commented Oct 26, 2021

@humphd before, the line-height of these were set to '2rem' so they collapsed on newline. This should be fixed by #2376, we can go back to display username/repo

@humphd
Copy link
Contributor Author

humphd commented Oct 26, 2021

Sure, let's try and see how it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: design Issues needing design or assets area: front-end type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants