Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix users MS e2e tests #2054

Closed
chrispinkney opened this issue Mar 30, 2021 · 2 comments · Fixed by #2173
Closed

Fix users MS e2e tests #2054

chrispinkney opened this issue Mar 30, 2021 · 2 comments · Fixed by #2173
Assignees
Labels
area: back-end area: microservices type: bug Something isn't working type: test Creation and development of test
Milestone

Comments

@chrispinkney
Copy link
Contributor

chrispinkney commented Mar 30, 2021

Line 3-4 of the users microservice prod-ify PR that just landed hardcodes an environment variable in order to satisfy e2e tests passing.

This is not ideal and only present because the tests for the users microservice are currently coded to send requests to / as opposed to http://localhost/v1/users. These tests need to get modified so they are actual e2e tests instead of unit tests.

This change could serve to complicate things with supertest, and so node fetch might have to be used as an alternative.

Once fixed the lines mentioned above can be removed from jest.config.e2e.js.

@humphd
Copy link
Contributor

humphd commented Apr 3, 2021

Let's get #2060 reviewed and merged before we start this, since I'm changing so much of the tests there. I also need this fix in order to get the pagination tests done, after it merges.

@chrispinkney
Copy link
Contributor Author

Agreed, that's the plan. Going to take a look at it with @manekenpix now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: back-end area: microservices type: bug Something isn't working type: test Creation and development of test
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants