Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Next.js Header height #1680

Closed
izhuravlev opened this issue Feb 9, 2021 · 3 comments
Closed

Fix Next.js Header height #1680

izhuravlev opened this issue Feb 9, 2021 · 3 comments
Assignees
@rjayroso
Labels
5 min fix Fixable in 5 minutes or less area: css styling Anything related to CSS styling area: front-end area: nextjs Nextjs related issues type: bug Something isn't working
Milestone
1.7 Release

Comments

@izhuravlev
Copy link
Contributor

izhuravlev commented Feb 9, 2021 •
edited
Loading

What happened: After porting Header from Next to Gatsby, the height of the header is different

What should have happened: The height of the header should be the same as in the Gatsby version.

How to reproduce it (as precise as possible):

Anything else we need to know?:

Environment:

  • OS:
  • Browser:
@izhuravlev izhuravlev added type: bug Something isn't working area: front-end area: css styling Anything related to CSS styling area: nextjs Nextjs related issues labels Feb 9, 2021
@izhuravlev izhuravlev added the 5 min fix Fixable in 5 minutes or less label Feb 9, 2021
@yuanLeeMidori yuanLeeMidori added this to the 1.7 Release milestone Feb 9, 2021
@PedroFonsecaDEV
Copy link
Contributor

@izhuravlev @rjayroso
We are porting to our new UI, and this bug doesn't need to be fixed.
Please check #1676 pick up an issue and assign yourself.

@PedroFonsecaDEV PedroFonsecaDEV added Blocked Can't do this, until something else is done and removed Blocked Can't do this, until something else is done labels Feb 10, 2021
@PedroFonsecaDEV
Copy link
Contributor

@izhuravlev @rjayroso

Sorry guys.
there is a change in our plans. We need to finish the port and have the old UI working 100% on the NEXTJs.

@PedroFonsecaDEV
Copy link
Contributor

Issue closed on #1738

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjayroso rjayroso

Labels
5 min fix Fixable in 5 minutes or less area: css styling Anything related to CSS styling area: front-end area: nextjs Nextjs related issues type: bug Something isn't working
Projects
None yet
Milestone
1.7 Release
Development

No branches or pull requests
4 participants
@izhuravlev @rjayroso @yuanLeeMidori @PedroFonsecaDEV