Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Slack integrations for failed or successful builds #1366

Open
humphd opened this issue Nov 15, 2020 · 13 comments
Open

Investigate Slack integrations for failed or successful builds #1366

humphd opened this issue Nov 15, 2020 · 13 comments
Assignees
Labels
area: deployment Production or Staging deployment area: tools developer experience Helping the Developer Experience type: enhancement New feature or request type: nice to have Feature that'd be nice to have, but not a priority

Comments

@humphd
Copy link
Contributor

humphd commented Nov 15, 2020

What would you like to be added:

Let's see what we can do to add some notifications to our #telescope Slack channel. Maybe there are existing tools that we can leverage for this, or maybe we can build our own (possibly as a separate repo).

Why would you like this to be added:

We have a number of situations that would be good to know about when the occur. For example:

  • dev or prod go down (e.g., something broke one of the servers)
  • dev or prod get deployed (e.g., new build available)

Probably there are other things, but these are the main ones that occur to me.

@humphd humphd added type: enhancement New feature or request developer experience Helping the Developer Experience type: nice to have Feature that'd be nice to have, but not a priority area: tools area: deployment Production or Staging deployment labels Nov 15, 2020
@humphd humphd changed the title Slack integrations Investigate Slack integrations for failed or successful builds Nov 15, 2020
@PedroFonsecaDEV
Copy link
Contributor

I would like to try it.

@humphd
Copy link
Contributor Author

humphd commented Nov 16, 2020

@PedroFonsecaDEV please assign yourself.

@sirinoks
Copy link
Contributor

sirinoks commented Feb 9, 2022

Good move to assign me

@sirinoks
Copy link
Contributor

sirinoks commented Feb 9, 2022

Research:
Github webhooks event: release
Making a Slack bot

What I need to find is an event when a build occurs on master, and when it breaks.

@sirinoks
Copy link
Contributor

Look into /tools
Autodeployment server

@humphd
Copy link
Contributor Author

humphd commented Feb 15, 2022

A build on the staging/production boxes is done when this function is called: https://github.com/Seneca-CDOT/telescope/blob/master/tools/autodeployment/builds.js#L17-L31

If the code is === 0 then it passed, otherwise it failed, so pseudo-code would be:

if(code !==0) {
  slackBot.sendMessage("Build failed...");
}

@RC-Lee RC-Lee added this to the 2.9 Release milestone Mar 14, 2022
@JerryHue
Copy link
Contributor

@sirinoks, what has been your progress related to this? I know that you were researching for any Slack APIs that would let you do this, but I don't know what you concluded with.

@sirinoks
Copy link
Contributor

@sirinoks, what has been your progress related to this? I know that you were researching for any Slack APIs that would let you do this, but I don't know what you concluded with.

There has been no progress since Feb 15th. I still need to figure out the automation stuff and I haven't looked there.

@cindyorangis
Copy link
Contributor

@sirinoks, what has been your progress related to this? I know that you were researching for any Slack APIs that would let you do this, but I don't know what you concluded with.

There has been no progress since Feb 15th. I still need to figure out the automation stuff and I haven't looked there.

Perhaps you can talk to @DukeManh , I remember he added a Slackbot but it was in the wrong channel so it was removed

@sirinoks
Copy link
Contributor

Perhaps you can talk to @DukeManh , I remember he added a Slackbot but it was in the wrong channel so it was removed

So, the problem isn't in the slackbot related stuff, but in automation stuff. But I'm pretty sure there is also someone to ask about that. Either way, I have limited time now. I might get to this, but I think I was told to prioritize docs for now.
I'm sorry for my inconsistency, I also want to have this done, since it's pretty interesting.

@JerryHue
Copy link
Contributor

@sirinoks, that's totally fine. In the case you'd prefer to prioritize documentation, we can push the issue to release 3.0. Let me know if you are okay with that.

@AmasiaNalbandian
Copy link
Contributor

Follow up with Dave for a meeting to discuss this.

@TueeNguyen TueeNguyen removed this from the 3.0-alpha Release milestone Mar 31, 2022
@humphd
Copy link
Contributor Author

humphd commented May 16, 2022

See also #3604

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: deployment Production or Staging deployment area: tools developer experience Helping the Developer Experience type: enhancement New feature or request type: nice to have Feature that'd be nice to have, but not a priority
Projects
None yet
10 participants