This repository has been archived by the owner on Apr 5, 2022. It is now read-only.
Update pino #26
Merged
Update pino #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kevan-Y
force-pushed
the
issues/issue-2499
branch
from
84e4c2b to
f4391cd
Compare
humphd
suggested changes
Jan 21, 2022
package.json
Outdated
| "helmet": "4.6.0", | ||
| "http-errors": "^1.8.0", | ||
| "ioredis": "^4.27.1", | ||
| "ioredis-mock": "^5.5.5", | ||
| "jsonwebtoken": "^8.5.1", | ||
| "node-fetch": "^2.6.1", | ||
| "pino": "^6.11.3", | ||
| "pino-colada": "^2.1.0" | ||
| "pino": "^7.6.4", |
There was a problem hiding this comment.
We have a weird mix of pinned and ^ versions in this file. In a follow-up, we should standardize (probably on pinned like Telescope). cc @DukeManh.
* Switch from express-pino-logger to pino-http * Standardize Dependencies
Kevan-Y
force-pushed
the
issues/issue-2499
branch
from
f4391cd to
8798e0a
Compare
humphd
approved these changes
Jan 21, 2022
|
We should do a release of Satellite this week to pick up this change and the node-fetch update that's coming. cc Sheriffs: @AmasiaNalbandian, @DukeManh |
|
@humphd, I agree |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2499
Fix: