Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dropdown] Search In-Menu Should Open With Keyboard #4490

Closed
andrewtrickett opened this issue Aug 28, 2016 · 5 comments
Closed

[Dropdown] Search In-Menu Should Open With Keyboard #4490

andrewtrickett opened this issue Aug 28, 2016 · 5 comments

Comments

@andrewtrickett
Copy link

andrewtrickett commented Aug 28, 2016

Search In-Menu dropdowns can't be opened by keyboard users on tab as it just skips to the next input.

If a tabindex is manually placed on the dropdown then the dropdown opens and closes straight away.

Fiddle

@jlukic jlukic added this to the 2.2.5 milestone Aug 29, 2016
@jlukic
Copy link
Member

jlukic commented Aug 29, 2016

I believe has.search on this like should be is.searchSelection
https://github.com/Semantic-Org/Semantic-UI/blob/master/src/definitions/modules/dropdown.js#L2186

Otherwise the searchable input in the menu will mistakenly get a tab index.

@andrewtrickett
Copy link
Author

Thanks for the quick reply.

I changed the code to is.searchSelection and it does now add a tabindex="0" to the dropdown, but then it immediately closes the dropdown when you try and open it, like the last dropdown on the fiddle with a manually added tabinddex. It looks like it is closing the dropdown when the search input gets focus.

@James1x0
Copy link

I think I have also been bitten by this. JSFiddle & repro instructions

Makes a bad experience for power users.

@jlukic
Copy link
Member

jlukic commented Dec 29, 2016

This is pretty bad

@jlukic
Copy link
Member

jlukic commented Dec 29, 2016

Fixed in next

jlukic added a commit that referenced this issue Dec 29, 2016
…xes issue with selectOnKeydown and html text
@jlukic jlukic closed this as completed Dec 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants