Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon] File Image Outline Icon - Applies image style #4145

Closed
icelord2 opened this issue Jun 21, 2016 · 2 comments
Closed

[Icon] File Image Outline Icon - Applies image style #4145

icelord2 opened this issue Jun 21, 2016 · 2 comments
Milestone

Comments

@icelord2
Copy link

Steps to Reproduce

  1. Add the File Image Outline icon

notice since the icon has image in its class name it applies the following
.ui.header>.image, .ui.header>img {
display: inline-block;
margin-top: .14285em;
width: 2.5em;
height: auto;
vertical-align: middle;
}

Expected
The width should be the same as the icon

Result
The Icon is applying the image style making it wider which can put it on a new line

Testcase

@yaboi
Copy link

yaboi commented Aug 22, 2016

I was having this problem, too. My HTML code renders as so:

<h1 class="ui top attached small header">
    <i class="fitted image icon"></i> Post Overview
</h1>

image icon is the only icon in the header with a width of 2.5em (by default) because it's picking up the .image class. The fix for this is to add :not(.icon) to line 82 in src/definitions/elements/header.less. Code would look like this:

.ui.header > .image:not(.icon),
.ui.header > img {
  display: inline-block;
  margin-top: @imageOffset;
  width: @imageWidth;
  height: @imageHeight;
  vertical-align: @imageAlignment;
}

@jlukic jlukic added this to the 2.2.4 milestone Aug 22, 2016
@jlukic jlukic modified the milestones: 2.2.5, 2.2.6, 2.2.7 Oct 28, 2016
@jlukic jlukic changed the title File Image Outline Icon - Applies image style [Icon] File Image Outline Icon - Applies image style Feb 20, 2017
@jlukic
Copy link
Member

jlukic commented Feb 21, 2017

Thanks for your patience here. The fix you suggested is quite reasonable. Added in 2.2.8

@jlukic jlukic closed this as completed Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants