Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Label] Use basicBackground with background #6440

Closed
wants to merge 1 commit into from
Closed

[Label] Use basicBackground with background #6440

wants to merge 1 commit into from

Conversation

ColinFrick
Copy link

Instead of background the property background-color was used.

Fixes #6439

@jlukic
Copy link
Member

jlukic commented Jun 18, 2018 •
edited
Loading

The variable is indeed background

https://github.com/Semantic-Org/Semantic-UI/blob/master/src/themes/default/elements/label.variables#L106

@basicBackground: none @white;

@kevinresol
Copy link

This fix is correct.

@co2meal co2meal mentioned this pull request Aug 24, 2018
Open
@y0hami y0hami mentioned this pull request Sep 6, 2018
Closed
@ColinFrick ColinFrick mentioned this pull request Sep 14, 2018
Closed
@y0hami y0hami mentioned this pull request Sep 20, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
@lubber-de

This comment was marked as spam.

Sign in to view
@ColinFrick ColinFrick closed this May 9, 2023
@brownspy1 brownspy1 mentioned this pull request Jun 29, 2024
Merged
@DarkCipherNinja DarkCipherNinja mentioned this pull request Oct 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@co2meal co2meal co2meal approved these changes

Assignees
No one assigned
Labels
Evaluating Bug / Change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ColinFrick @jlukic @kevinresol @lubber-de @co2meal @y0hami