Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update material theme font URLs to be '//' instead of 'http://' #4051

Merged
merged 2 commits into from
Jul 31, 2016
Merged

Update material theme font URLs to be '//' instead of 'http://' #4051

merged 2 commits into from
Jul 31, 2016

Conversation

arylatt
Copy link
Contributor

@arylatt arylatt commented May 20, 2016

The default material theme uses http:// for the fonts in every override file, which throws warnings on SSL enabled sites. This fixes that.

@cweagans
Copy link

IMO, switch to HTTPS instead of protocol relative URLs.

@jlukic
Copy link
Member

jlukic commented May 31, 2016

Should be https like default theme.

@jlukic jlukic added this to the 2.2.1 milestone May 31, 2016
@arylatt
Copy link
Contributor Author

arylatt commented May 31, 2016

I have forced HTTPS on the URLs now.

@cweagans
Copy link

👍

jlukic added a commit that referenced this pull request Jul 31, 2016
@jlukic
#4051 - Fixes paths to roboto in material theme
dbafd8d
@jlukic jlukic merged commit 377f94b into Semantic-Org:next Jul 31, 2016
jlukic added a commit that referenced this pull request Jul 31, 2016
@jlukic
Rlsnotes #4051
aa587c6
@arylatt arylatt deleted the next branch July 31, 2016 19:39
@amingilani amingilani mentioned this pull request Jun 18, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Confirmed Bug
Projects
None yet
Milestone
2.2.3
Development

Successfully merging this pull request may close these issues.
3 participants
@arylatt @cweagans @jlukic