Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI stackable menu does not stack the child "right menu" #3604

Closed
mixerp opened this issue Jan 24, 2016 · 17 comments
Closed

UI stackable menu does not stack the child "right menu" #3604

mixerp opened this issue Jan 24, 2016 · 17 comments

Comments

@mixerp
Copy link

mixerp commented Jan 24, 2016

The right menu inside ui stackable menu does not display correctly on mobile devices

<div class="ui stackable menu">
  <a class="item">Browse</a>
  <a class="item">Submit</a>
  <div class="right menu">
    <a class="item">Sign Up</a>
    <a class="item">Help</a>
  </div>
</div>

Example:
http://jsfiddle.net/7wpm7bka/

@ThreeSevenths
Copy link

I've been struggling with this as well.

@jlukic jlukic added this to the 2.1.9 milestone Feb 18, 2016
@jlukic
Copy link
Member

jlukic commented Feb 18, 2016

This should be easy

@eveevans
Copy link

Do you want to handle this ?
or need help ?
:)

@jlukic
Copy link
Member

jlukic commented Feb 19, 2016

Got it

@mixerp
Copy link
Author

mixerp commented Feb 19, 2016

Thanks jack. You're a rockstar!

@jlukic jlukic modified the milestones: 2.1.9, 2.2 May 1, 2016
@eskiesirius
Copy link

I am still having this kind of problem, how to fix this?

@Unnumbered
Copy link

@eskiesirius you may use '.right.item' instead of '.right.menu .item'.

@ronlut
Copy link

ronlut commented Aug 11, 2016

I'm still getting this behavior as well..
Right menu items are unstackable (except the first item).
Any plans to fix it? @jlukic

@jlukic jlukic reopened this Aug 12, 2016
@jlukic jlukic modified the milestones: 2.2.x, 2.2 Aug 12, 2016
@rasgo-cc
Copy link

+1: Only the first item on the right menu appears stacked along with the left menu items

@lednhatkhanh
Copy link

+1 This need to be fixed!

@arlyon
Copy link

arlyon commented Sep 18, 2016

here's an illustration of the problem, and a (bad) fix to illustrate what is happening to the other items:

https://jsfiddle.net/arlyon/h5e877mm/1/ (just make sure you have the result set to mobile width)

Essentially the other items in .menu.right are still being placed horizontally. The parent menu correctly stacks as it should, but .menu.right.stackable doesn't stack the items in menu right to match its parent.

@wtfuii
Copy link

wtfuii commented Sep 29, 2016

This solved it for me:

<div class="ui stackable menu">
    <a class="item">My first left item</div> 
    <a class="item">My second left item</a>
    <a class="right item">My first right item</a> 
    <a class="item">My second right item</a> 
</div>

There may be a missing border on the right side, but currently this seems to be the best solution.

@droid-sheep
Copy link

droid-sheep commented Nov 20, 2016

It's right, the solution from @wtfuii has worked perfectly for me. But you have to deal with the margin-left of the .items

@Nsbx
Copy link

Nsbx commented Mar 1, 2017

Hello,
Problem alway present at this date ;)

@traverse
Copy link

traverse commented Mar 1, 2017

I think the following addition would be sufficient to fix this issue, it does require some testing though.

in menu.less:

@media only screen and (max-width: @largestMobileScreen) {

  ...

  .ui.stackable.menu .right.menu,
  .ui.stackable.menu .left.menu {
    flex-direction: column;
  }
}

If someone else would like to create a pull request go ahead and do it since I won't have enough time at the moment to do it.

@jlukic
Copy link
Member

jlukic commented Apr 10, 2017

I've fixed this in 2.2.11

@jlukic jlukic closed this as completed Apr 10, 2017
@imtinge
Copy link

imtinge commented Jun 21, 2017

I have add code like this


@media only screen and (max-width: 767px) {
  .ui.stackable.menu .right.menu {
    flex-direction: column;
  }
}

but if I add .pusher to body,to stick the footer(https://philipwalton.github.io/solved-by-flexbox/demos/sticky-footer/)
the blow stackable elements will cover the menu
2017-06-22 9 13 56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests