Fixed inconsistent use of media query breakpoints #3180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- @largest* should only be used by max-width queries - @*Breakpoint should only be used by min-width queries
|
I can confirm these should all be @largest(X)Size as you've specified. Merging in. |
jlukic
added a commit
that referenced
this pull request
Oct 14, 2015
Fixed inconsistent use of media query breakpoints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
modal.lessandstep.less, amax-widthof@computerBreakpointis used, causing an inconsistency when the browser is exactly 992px width (ie most queries switch on the 991-992 change, but these switch on the 992-993 change).@largest*should only be used bymax-widthqueries@*Breakpointshould only be used bymin-widthqueriesThis PR makes the use of these variables more consistent.