Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] No results dialog message not being dismissed if it's clicked #3039

Closed
jeff3yan opened this issue Sep 16, 2015 · 2 comments
Closed
Milestone

Comments

@jeff3yan
Copy link

If an API search is performed where there are no results, a no results message pops up. After this popup appears, it can be dismissed by clicking anywhere on the page.

However, if the popup message itself is clicked after it appears - then it does not dismiss even after trying to click around on the page. Only if the search text field is refocused, and another search performed, does it finally dismiss.

@jlukic jlukic added this to the 2.1.5 milestone Sep 17, 2015
@jlukic
Copy link
Member

jlukic commented Sep 17, 2015

Although you didnt provide a test case this is clear enough to see as an issue in the docs.

@jlukic jlukic modified the milestones: 2.1.5, 2.1.7 Nov 6, 2015
@jlukic
Copy link
Member

jlukic commented Nov 30, 2015

I've modified how input blur handles closing results in 2.1.7

Previously it would just look for a mousedown event on search results to assume that the results have been clicked, and that an action occurring there should decide whether results should close.

Now it sets a one type event to wait for click to bubble from results and determine if the click action actually makes the results close.

@jlukic jlukic closed this as completed Nov 30, 2015
jlukic added a commit that referenced this issue Nov 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants