Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimmer animation gets stuck #2469

Closed
awfm9 opened this issue Jun 27, 2015 · 3 comments
Closed

Dimmer animation gets stuck #2469

awfm9 opened this issue Jun 27, 2015 · 3 comments

Comments

@awfm9
Copy link

awfm9 commented Jun 27, 2015

On the latest beta, I had an issue with an image that dims on hover. The image would sometimes remain stuck in the dimmed state, with further mouse hovers doing nothing.

I was able to reliably reproduce the problem by very quickly moving the mouse across the picture several times.

The JS of Semantic UI bugs out at line 16972:

return module.cache.animation || false;

The message:

Uncaught TypeError: Cannot read property 'animation' of undefined

I didn't dig into the code, but adding the following to the currentAnimation function seems to solve the issue:

if (module.cache === undefined) {
    return false
}
@jlukic jlukic added this to the 2.0 RC milestone Jun 27, 2015
@jlukic jlukic modified the milestones: 2.1, 2.0 RC Jun 30, 2015
@startswithaj
Copy link

+1 get this same problem

element.modal('hide') == Uncaught TypeError: Cannot read property 'animation' of undefined
at Object.$.fn.transition.$allModules.each.module.get.currentAnimation
currentAnimation: function() {
return module.cache.animation || false;
},

As @awishformore module.cache is not defined. and so when accessing cache.animation it throws and error. It needs to check if cache is defined first.

@jlukic jlukic modified the milestones: 2.0.3, 2.1 Jul 10, 2015
@jlukic
Copy link
Member

jlukic commented Jul 10, 2015

I'll look at this tomorrow.

@jlukic
Copy link
Member

jlukic commented Jul 10, 2015

I've gone ahead and fixed the JS error. I don't have a reproducible test case so closing for now (asssumably fixed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants