Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Comments] Add Inverted Variation #2348

Closed
paulwal opened this issue Jun 2, 2015 · 5 comments
Closed

[Comments] Add Inverted Variation #2348

paulwal opened this issue Jun 2, 2015 · 5 comments

Comments

@paulwal
Copy link

paulwal commented Jun 2, 2015

Hi, I'm trying to switch between day & night views; so toggling between a light color scheme and a dark color scheme. I like how Semantic UI makes this really easy with the Menu using the "inverted" class.

To illustrate what I'm trying to do, go here and click Chat:
http://www.sessionlessons.com/8

You can see the Comment view with the default styling. Now click Config and turn on night view. The "Night view" text color css is changed manually via javascript. Now click back to Chat and you can see its colors are unchanged. Is there a way to change it using the inverted class or does it just need to be styled manually? Also, is there a list of which elements/collections/views/modules that the inverted class can be used on? Thanks

@jlukic
Copy link
Member

jlukic commented Jun 2, 2015

Comments is definitely missing an inverted variation. I'll add that as an enhancement.

In general, variations like inverted are only defined in the context of UI components. Inversion is often more complex than just flipping a single text color, and other element variations may need to be adjusted as well. For example inverted menu has to define inversion in the context of all other types & variations, pointing, secondary, text, etc.

@jlukic jlukic changed the title Inverting text colors [Comments] Add Inverted Variations Jun 2, 2015
@jlukic jlukic changed the title [Comments] Add Inverted Variations [Comments] Add Inverted Variation Jun 2, 2015
@jlukic jlukic added this to the 2.x Changes milestone Jun 2, 2015
@paulwal
Copy link
Author

paulwal commented Jun 2, 2015

Ok great, thanks for the explanation.

@tmikaeld
Copy link

tmikaeld commented Jul 3, 2015

So inverted text menu is coming as well?

@stale
Copy link

stale bot commented Feb 24, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 24, 2018
@stale stale bot closed this as completed Mar 26, 2018
@Atulin
Copy link

Atulin commented Jul 5, 2018

Opening again, 3 years later. How's the progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants