Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Button] Add Text color to Basic Button :focus #2264

Closed
avalanche1 opened this issue May 16, 2015 · 6 comments
Closed

[Button] Add Text color to Basic Button :focus #2264

avalanche1 opened this issue May 16, 2015 · 6 comments
Labels
Enhancement
Milestone
2.1

Comments

@avalanche1
Copy link
Member

.basic.button :focus should have the same styling as .basic.button :hover
otherwise you cannot visually distinguish where your focus is at when tabbing through them
http://jsfiddle.net/efp8z6Ln/150/ (try tabbing through all btns)
@ikourfaln
Copy link

+1

@jlukic jlukic added this to the 2.0 milestone May 19, 2015
jlukic added a commit that referenced this issue May 19, 2015
@jlukic
#2264, add focus colors to site, add focus rules for all possible but…
d7f7bab 
…ton styles
@jlukic
Copy link
Member

jlukic commented May 19, 2015

This added a few kb to rules but is probably worth it in the long run. I've moved all docs examples to be keyboard focusable to help demonstrate.

@jlukic jlukic closed this as completed May 19, 2015
@avalanche1
Copy link
Member Author

Wow, that was a lot of work! But definitely worth it! You're my hero!

@avalanche1
Copy link
Member Author

box-shadow is, but color is still not changed on :focus.

@jlukic jlukic reopened this Jul 4, 2015
@jlukic
Copy link
Member

jlukic commented Jul 4, 2015

I can confirm text color is missing from :focus

@jlukic jlukic modified the milestones: 2.x Changes, 2.0 Jul 4, 2015
@jlukic jlukic modified the milestones: 2.1, 2.x Changes Jul 29, 2015
@jlukic jlukic changed the title .basic.button:focus [Button] Add Basic Button :focus Aug 6, 2015
@jlukic jlukic changed the title [Button] Add Basic Button :focus [Button] Add Text color to Basic Button :focus Aug 6, 2015
jlukic added a commit that referenced this issue Aug 14, 2015
@jlukic
Fix focus color on basic button #2264
8cfcf56
jlukic added a commit that referenced this issue Aug 14, 2015
@jlukic
Rlsnotes #2264
7d23712
@jlukic jlukic closed this as completed Aug 14, 2015
@jlukic
Copy link
Member

jlukic commented Aug 14, 2015

Added in 2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
3 participants
@jlukic @ikourfaln @avalanche1