You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A util for getting spreadable props, to handle this use case:
letcheckboxProps=_.clone(this.props);deletecheckboxProps.settings;// all modules need to do thisdeletecheckboxProps.className;// this would be passed in// then<input{...checkboxProps}/>
We need to remove props.settings from all Semantic UI Modules. Also, many components need to exclude certain props from being spread as they belong elsewhere. Like the checkbox example above, and this message example:
Lack of this util is also currently resulting in double rendered children. The children are rendered once by the parent component, but also the props.children are spread onto the component, so they are rendered twice.
A util for getting spreadable props, to handle this use case:
We need to remove
props.settings
from all Semantic UI Modules. Also, many components need to exclude certain props from being spread as they belong elsewhere. Like the checkbox example above, and this message example:The icon prop belongs as classes on the icon inside the message, then the rest of the props are spread.
This should be abstracted away with a util that understands what to do to get spreadable props.
The text was updated successfully, but these errors were encountered: