Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select Input Needs to be Controlled Component #48

Closed
athurman opened this issue Oct 12, 2015 · 1 comment
Closed

Select Input Needs to be Controlled Component #48

athurman opened this issue Oct 12, 2015 · 1 comment
Labels

Comments

@athurman
Copy link
Contributor

Currently, the Select element does not take in a name Proptype, and therefore when used in a Form component, renders the serialized JSON key for that specific input as null.

Also, the select element needs to have a handleChange() function to make it a controlled component.

@levithomason
Copy link
Member

All components now spread user props, so the name and change handlers are spread onto the <input />.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants