Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button - Labeled Icon - Darken background rotates with icon #4088

Closed
flppv opened this issue Oct 13, 2020 · 4 comments
Closed

Button - Labeled Icon - Darken background rotates with icon #4088

flppv opened this issue Oct 13, 2020 · 4 comments
Labels

Comments

@flppv
Copy link
Contributor

flppv commented Oct 13, 2020

Bug Report

image

Steps

Create a Button with Labeled Icon, and make Labeled Icon rotating with loading prop:

<Button
  labelPosition="right"
  size="huge"
  icon
>
  Test
  <Icon name="circle notch" loading />
</Button>

Expected Result

I expect background to stay static and only Icon content to be rotated

Actual Result

Background rotates together with Icon

Version

2.0.0

Testcase

https://codesandbox.io/s/elated-framework-kgepn?file=/src/App.js

@welcome
Copy link

welcome bot commented Oct 13, 2020

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

@flppv
Copy link
Contributor Author

flppv commented Oct 13, 2020

I think I can fix it by myself a bit later tonight, just want to get a confirmation it is considered as a bug, not a feature.
IMO, need to move rotate animation from <i> element to it's child :before

@brianespinosa
Copy link
Member

@flppv Looks like this is definitely an issue... but the CSS that is targeting these elements is not part of SUIR. You can open an issue in the parent SUI project for this. Or you can write some global CSS that overrides those defaults to move it.

@lubber-de

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants