Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image link centered does not work #3953

Closed
MattSom opened this issue May 29, 2020 · 3 comments
Closed

Image link centered does not work #3953

MattSom opened this issue May 29, 2020 · 3 comments
Labels

Comments

@MattSom
Copy link

MattSom commented May 29, 2020

Feature Request

Problem description

This is the very same issue with native Semantic-UI.

An Image tag with centered attribute gets display: block formatting making it truly centered. However an Image can have an as='a' attribute as well, which will wrap the <img> tag inside <a><a/> tags.

Example:

<Image centered ..... />
<img class="ui small centered image" alt='Disponible en Google Play' src='https://play.google.com/intl/en_us/badges/images/generic/es_badge_web_generic.png'/>

<Image as='a' centered ..... />
<a class="ui small centered image" href=''>
    <img alt='Disponible en Google Play' src='https://play.google.com/intl/en_us/badges/images/generi/es_badge_web_generic.png'/>
</a>

Proposed solution

If the Image tag is used as a link while being centered, the anchor tag formatting should be overwritten to this:

a.ui.image.centered{
    display: block;
}

instead of display: inline-block.

@welcome
Copy link

welcome bot commented May 29, 2020

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

@layershifter
Copy link
Member

We can't fix it there as we don't handle CSS in this repo, but I reported it Fomantic UI team. Let's see how it will go 🚀
Thanks for reporting 👍

fomantic/Fomantic-UI#1608

@lubber-de

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants