Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup has issues with RefForward #3592

Closed
kschrader02 opened this issue May 1, 2019 · 2 comments · Fixed by #3594
Closed

Rollup has issues with RefForward #3592

kschrader02 opened this issue May 1, 2019 · 2 comments · Fixed by #3594
Labels

Comments

@kschrader02
Copy link

Bug Report

Steps

When using rollup it has issues with RefForward and fills in the children and innerRef with undefined, undefined[(undefined, undefined)] respectively, which causes the exported bundle to not work. The only difference we could find when compared against Ref and RefFindNode was that RefForward imports PropTypes like import * as PropTypes from 'prop-types' whereas Ref and RefFindNode use import PropTypes from 'prop-types'.

Expected Result

To be able to export code that uses semantic using rollup with no issues

Actual Result

Exports RefForward with undefined props which brakes everything. It doesn't make sense that it has no issue with Ref and RefFindNode. So we think it has something to do with the way PropTypes is imported.

Version

0.86.0

@layershifter
Copy link
Member

Thanks for a catch, was fixed in #3594 👍

@kschrader02
Copy link
Author

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants