Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to React 16 #2747

Closed
2 of 5 tasks
levithomason opened this issue Apr 28, 2018 · 3 comments
Closed
2 of 5 tasks

Update to React 16 #2747

levithomason opened this issue Apr 28, 2018 · 3 comments

Comments

@levithomason
Copy link
Member

levithomason commented Apr 28, 2018

React 16 offers some updates that we should implement, however, we'll need to drop support for React 15 when doing so. Let's batch these changes into an upcoming major release:

@Semantic-Org/react-maintainers feel free to add to this list at will...

@layershifter
Copy link
Member

Added Breadcrumb to list, there is quite unfriendly code.

@packetstracer
Copy link

Maybe you should add a Fix for unsafe lifecycle methods for asynchronous rendering.

In the project I'm working currently, since we activated the new React's Strict Mode, we are getting a lot of console warnings about using unsafe lifecycle methods y some of the components.

For example:

componentWillMount: Please update the following components to use componentDidMount instead: Dropdown

componentWillReceiveProps: Please update the following components to use static getDerivedStateFromProps instead: Dropdown, Menu, Tab

componentWillReceiveProps: Please update the following components to use static getDerivedStateFromProps instead: AccordionAccordion

componentWillReceiveProps: Please update the following components to use static getDerivedStateFromProps instead: Checkbox

@layershifter
Copy link
Member

@packetstracer see #2732, feel free to contribute 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants