Pagination: invalid ARIA attribute ariaLabel

[AndreiEnache]

Steps

Create a small pagination component.
When the component mounts, a warning is displayed.

Expected Result

Not show the warning.

Actual Result

Shows the warning.

Version

• semantic-ui-react: 0.78.3
• react: 16.2.0
• react-dom: 16.2.0

Testcase

https://codesandbox.io/s/9l90v9xnwp

[welcome]

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

[brianespinosa]

Valid bug. I do not think this is a duplicate. PRs welcome.

[tphan18]

Confirmed. This is a valid bug.

[gtod]

I think the problem is that the arialLabel prop on PaginationItem is being copied into the MenuItem in addition to the correct aria-label prop.

I say this only because if you replace the current MenuItem.create line here with the following 3 lines the error goes away:

  var props = Object.assign({}, this.props);
  delete props.ariaLabel;
  return MenuItem.create(props, {

[brianespinosa]

@gtod there is already a PR being worked on for this. 🎉 Please see above history for reference to #2607

[tphan18]

I don't think the issue is fixed in v0.79.0.

[layershifter]

Create a new issue with repro on codesandbox, please.