Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup doesn't work correctly until it's clicked multiple times #2471

Closed
kaiyoma opened this issue Jan 27, 2018 · 2 comments
Closed

Popup doesn't work correctly until it's clicked multiple times #2471

kaiyoma opened this issue Jan 27, 2018 · 2 comments

Comments

@kaiyoma
Copy link

kaiyoma commented Jan 27, 2018

Steps

Implement the controlled popup as described here:

https://react.semantic-ui.com/modules/popup#popup-example-controlled

Expected Result

The popup should display correctly when the trigger is clicked the first time or if open={true} initially. Also, the open prop should be documented here:

https://react.semantic-ui.com/modules/popup

Actual Result

The trigger has to be clicked multiple times before the popup appears in the correct place. If open={false} initially, the trigger has to be clicked three times; if open={true}, the trigger has to be clicked two or four times.

Also, the open prop doesn't appear in the documentation.

Version

0.77.2

Testcase

This shows the problem when open={true} initially: https://codesandbox.io/s/20lm45zn00

Notice how the rendering of the popup is very wrong and stuck in the upper-right corner of the pane. If you click the link twice, then the popup appears where it should.

@kaiyoma
Copy link
Author

kaiyoma commented Jan 27, 2018

Ah, I think I see the problem: I wasn't including the Semantic UI CSS, which apparently is necessary in this case for everything to work properly. If someone could verify that, that would be great.

There's still a minor issue with the open prop not being documented though.

@layershifter
Copy link
Member

Duplicate #1065.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants