Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Cannot run local tests without modifying test config #2227

Closed
patrikmolsson opened this issue Oct 21, 2017 · 2 comments
Closed

Test: Cannot run local tests without modifying test config #2227

patrikmolsson opened this issue Oct 21, 2017 · 2 comments

Comments

@patrikmolsson
Copy link
Contributor

patrikmolsson commented Oct 21, 2017

When running yarn test on local environment (Arch Linux) I ran into the issues described in: puppeteer/puppeteer#290. Although, just adding the flags as described in the referred issue wasn't enough.

I also had to rename the browser:

browsers: ['ChromeHeadless'],
in the test config file to reflect the key in the customLaunchers:

I.e. I renamed ChromeHeadless browser to puppeteer and added the flags --no-sandbox and --disable-setuid-sandbox on the customLauncher, since the flags wasn't respected when trying to run the browser. This leads me to believe the flag present today (--stack-trace-limit 50000) isn't respected as well.

Is this something we need to address? We should maybe communicate how to do the work-around to add the --no-sandbox and --disable-setuid-sandbox flags in case more users run into this issue as well.

@patrikmolsson patrikmolsson changed the title Test: Local test environment doesn Test: Cannot run local tests without modifying test config Oct 21, 2017
@layershifter
Copy link
Member

@patrikmolsson Thanks 👍 Feel free to open PR that will contain described changes.

@patrikmolsson
Copy link
Contributor Author

@layershifter Sure, I'll get to it the upcoming week :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants