Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion does not open and close anymore. Worked in 0.71.5 and not in 0.74.2 #2186

Closed
darewreck54 opened this issue Oct 11, 2017 · 3 comments
Labels

Comments

@darewreck54
Copy link

Steps

  1. https://codepen.io/darewreckk/pen/pWKXNd?editors=1111 (working open and closing of accordion 0.71.5)
  2. https://codepen.io/darewreckk/pen/GMGbrp?editors=1111 (not working and closing of accordion 0.74.2)

It works when you use the panels props for Accordion, but if you choose to fill in the child yourself it's broken

Expected Result

  1. https://codepen.io/darewreckk/pen/pWKXNd?editors=1111 (working open and closing of accordion 0.71.5)

open and closing of the accordion

Actual Result

https://codepen.io/darewreckk/pen/GMGbrp?editors=1111 (not working and closing of accordion 0.74.2)

Accordion doesn't open and close

Version

0.74.2

Testcase

Test Case is above

@brianespinosa
Copy link
Member

@darewreck54 there was a breaking refactor change to Accordion in 0.74.0. Changes like this should show up in the Changelog. https://github.com/Semantic-Org/Semantic-UI-React/blob/master/CHANGELOG.md#v0740-2017-09-24

@darewreck54
Copy link
Author

ic. Thanks it was confusing because the documentation usage of accordion has not been updated. Maybe if possible put a note of this.

@layershifter
Copy link
Member

There was a breaking change in #1375.

it was confusing because the documentation usage of accordion has not been updated

All examples were updated and work correctly, if any example there doesn't work, please create the new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants