-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Card subcomponents are missing textAlign
props
#2027
Comments
I am trying to do this change. Also I'm a new contributor, can you please help me out with commit message? |
Solved the tests. |
Awesome! Go ahead an open a PR so folks know this is taken. In your PR description, please note that it
Yes, please.
See Segment.js for example: PropTypes.oneOf(_.without(SUI.TEXT_ALIGNMENTS, 'justified')),
Yes, please. We are just listing them explicitly, see Table typings for example. textAlign?: 'center' | 'left' | 'right'; |
Opened a PR and finished changes. |
Per SUI core, a Card's children can be aligned:
https://github.com/Semantic-Org/Semantic-UI/blob/master/dist/components/card.css#L203
This is true for all Card subcomponents.
The text was updated successfully, but these errors were encountered: