Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AutoControlledComponent throws warning in React 16 #1761

Closed
apiv opened this issue Jun 12, 2017 · 2 comments
Closed

AutoControlledComponent throws warning in React 16 #1761

apiv opened this issue Jun 12, 2017 · 2 comments
Labels
bug help wanted

Comments

@apiv
Copy link
Contributor

apiv commented Jun 12, 2017

Steps

  1. Upgrade to React 16
  2. Place any of the AutoControlledComponents in your app

Expected Result

It should render without warning

Actual Result

It renders with the warning Warning: Dropdown.componentWillMount(): Assigning directly to this.state is deprecated (except inside a component's constructor). Use setState instead.
screen shot 2017-06-12 at 10 32 06 am

Version

0.68.5

Testcase

It seems to be caused by this line: src/lib/AutoControlledComponent.js:149. I'll open a PR shortly so we can continue to fully support React 16.
@levithomason
Copy link
Member

It seems to be caused by this line: src/lib/AutoControlledComponent.js:149. I'll open a PR shortly so we can continue to fully support React 16.

Awesome, thanks much.

@apiv apiv mentioned this issue Jun 15, 2017
Closed
@layershifter
Copy link
Member

Seems that same problem is here, #1682.

@layershifter layershifter mentioned this issue Jun 25, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@apiv @levithomason @layershifter