Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface 'ConfirmProps' incorrectly extends interface 'ModalProps' #1612

Closed
Grmiade opened this issue Apr 23, 2017 · 8 comments
Closed

Interface 'ConfirmProps' incorrectly extends interface 'ModalProps' #1612

Grmiade opened this issue Apr 23, 2017 · 8 comments

Comments

@Grmiade
Copy link

Grmiade commented Apr 23, 2017

Interface 'ConfirmProps' incorrectly extends interface 'ModalProps'
Property 'content' is optional in type 'ConfirmProps' but required in type 'ModalProps'.

Steps

  • Compile Typescript project with react-semantic-ui

Expected Result

  • Success

Actual Result

  • Error

capture d ecran 2017-04-23 a 23 18 49

Version

0.68.1

@vincaslt
Copy link

Getting the same error.

@layershifter
Copy link
Member

Duplicate, will be fixed by #1611

@levithomason
Copy link
Member

Released in [email protected].

@Grmiade
Copy link
Author

Grmiade commented Apr 24, 2017

And it's not over ^^'
capture d ecran 2017-04-24 a 17 30 01
Statictic :)

@levithomason
Copy link
Member

Could you double confirm the installed version? npm ls semantic-ui-react?

@levithomason
Copy link
Member

@layershifter if this is a current issue, could we simply add a compile test to the TS tests?

@Grmiade
Copy link
Author

Grmiade commented Apr 24, 2017

0.68.2
capture d ecran 2017-04-24 a 17 36 43

@levithomason
Copy link
Member

Thanks much for the confirmation. I've posted this here: #1621. For now, you should downgrade until we ship a bug fix. Hopefully will be today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants