Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal missing property declaration (TypeScript) for closeOnDimmerClick, closeOnDocumentClick #1398

Closed
raptoria opened this issue Feb 28, 2017 · 4 comments

Comments

@raptoria
Copy link

ERROR in ./src/components/Modal/AssignBasketModal/AssignBasketModal.tsx
(34,42): error TS2339: Property 'closeOnDocumentClick' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<Component<ModalProps, ComponentState>> & { childre...'.

Needs to be added to Types:
closeOnDimmerClick
closeOnDocumentClick

@levithomason
Copy link
Member

This will be done in #1169. Those are Portal props, which the Modal composes.

@layershifter
Copy link
Member

However, these props are in latest version.

@layershifter
Copy link
Member

@raptoria Can you post a fragment of code that causes error? Possible, it's same problem like in #1400.

@raptoria
Copy link
Author

raptoria commented Mar 1, 2017

as of 0.66.0 there are no errors!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants