Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress bar always shows progress label when using value/total #1352

Closed
levithomason opened this issue Feb 20, 2017 · 3 comments
Closed

Progress bar always shows progress label when using value/total #1352

levithomason opened this issue Feb 20, 2017 · 3 comments
Labels

Comments

@levithomason
Copy link
Member

levithomason commented Feb 20, 2017

The value inside the bar indicating the current progress is optional:

image

However, when the value and total props are used the progress is always shown:

<Progress value={2} total={3}  />

image

We should only show the progress value when the progress prop is present or the label='ratio|percent' prop is present.

@BrainMaestro
Copy link
Contributor

Can I pick this up?

@layershifter
Copy link
Member

@BrainMaestro Yes, it will be awesome 👍

@levithomason
Copy link
Member Author

Released in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants