Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: updated safe gas multiplier #2585

Merged
merged 2 commits into from
May 3, 2021
Merged

feat: updated safe gas multiplier #2585

merged 2 commits into from
May 3, 2021

Conversation

andregoncalves
Copy link
Collaborator

@andregoncalves andregoncalves commented May 3, 2021 •
edited
Loading

  • Safe Gas Limit multiplier is now set at 1.5 (same as metamask)
  • Multiplier is now configured via env var SAFE_GAS_MULTIPLIER

@andregoncalves andregoncalves self-assigned this May 3, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 19156

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 39.145%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/token/token-service.js 0 1 0.0%
Totals Coverage Status
Change from base Build 19155: 0.0%
Covered Lines: 3920
Relevant Lines: 9088
💛 - Coveralls

@andregoncalves andregoncalves merged commit 1f9c609 into dev May 3, 2021
@andregoncalves andregoncalves deleted the 2575-updated-and-configurable-gas-limit branch May 3, 2021 17:16
andregoncalves added a commit that referenced this pull request May 4, 2021
@andregoncalves @sk91 @maycon-mello
Release 1.9.3 (#2587)
9baa003 
* fix: disable notaries application button while loading kyc requirements (#2571)

* Fix passports marketplace missing data check (#2572)

* feat: WalletConnect (#2580)

* feat: update selfkey-ui

* feat: WalletConnect scan qr-code and manage sessions (#2579)

* feat: refactor deep link WalletConnect connector

* feat: ui adjustments to WalletConnect sign and transaction screens (#2579)

* fix: dashboard token list UI fix (#2581)

* fix: default gas and nonce (#2583)

* fix: frameless border and sidebar in windows (#2586)

* feat: safe gas multiplier (#2585)

* feat(version): bump to 1.9.3

Co-authored-by: Kovalov Maxim <[email protected]>
Co-authored-by: Maycon Mello <[email protected]>
Co-authored-by: Andre Goncalves <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maycon-mello maycon-mello Awaiting requested review from maycon-mello

Assignees

@andregoncalves andregoncalves

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andregoncalves @coveralls