Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 Bug] [Python] setting remote_server_addr in RemoteConnection() is deprecated #14686

Closed
pquentin opened this issue Oct 30, 2024 · 1 comment · Fixed by #14690
Closed

Comments

@pquentin
Copy link

pquentin commented Oct 30, 2024

What happened?

#13286 added a new warning that was released in 4.26.0. Unfortunately there is still code in Selenium that triggers this warning. This happens with at least with the Firefox and Chromium webdrivers. This broke our CI as we fail on unknown warnings.

How can we reproduce the issue?

My use case is urllib3 using pytest-pyodide, but this can be reproduced with the "Getting Started" sample:

from selenium import webdriver

driver = webdriver.Firefox()
driver.get("http://www.python.org")
assert "Python" in driver.title
driver.close()

Then run with warning enableds using python -Wall sample.py.

Relevant log output

/.../urllib3/.nox/emscripten-firefox/lib/python3.12/site-packages/selenium/webdriver/firefox/remote_connection.py:35: DeprecationWarning: setting remote_server_addr in RemoteConnection() is deprecated, set in ClientConfig instance instead
  super().__init__(

Operating System

Ubuntu

Selenium version

Python 4.26.0

What are the browser(s) and version(s) where you see this issue?

Chrome, Firefox

What are the browser driver(s) and version(s) where you see this issue?

Not sure.

Are you using Selenium Grid?

No response

Copy link

@pquentin, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@pquentin pquentin changed the title [🐛 Bug]: setting remote_server_addr in RemoteConnection() is deprecated, set in ClientConfig instance instead [🐛 Bug] [Python] setting remote_server_addr in RemoteConnection() is deprecated Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants