Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 Bug]: PyPI: selenium 4.17.0 whl is not defining strong version requirement to typing-extensions #13488

Closed
rpysz opened this issue Jan 23, 2024 · 5 comments

Comments

@rpysz
Copy link

rpysz commented Jan 23, 2024

What happened?

https://pypi.org/project/selenium/#history

After release of selenium 4.17.0 our builds started failing due to the conflict between versions of selenium and typing extensions. Starting from 4.17.0 selenium requires typing-extensions in version 4.9.0.

Using selenium 4.17.0 with older typing-extensions (matched by PIP) ends with build errors. Enforcing selenium==4.16.0 fixes the issue.
Selenium wheel package should define strong requirement on typing-extensions version in metadata.

How can we reproduce the issue?

Build a project using the newest version selenium and old version of typing_extensions (for example, typing-extensions-3.10.0.2).

Relevant log output

[2024-01-23T06:55:46.907Z] Traceback (most recent call last):
[2024-01-23T06:55:46.907Z]   File "/apps/superset/virtualenv/bin/superset", line 5, in <module>
[2024-01-23T06:55:46.907Z]     from superset.cli.main import superset
[2024-01-23T06:55:46.907Z]   File "/apps/superset/virtualenv/lib/python3.8/site-packages/superset/__init__.py", line 21, in <module>
[2024-01-23T06:55:46.907Z]     from superset.app import create_app
[2024-01-23T06:55:46.907Z]   File "/apps/superset/virtualenv/lib/python3.8/site-packages/superset/app.py", line 23, in <module>
[2024-01-23T06:55:46.907Z]     from superset.initialization import SupersetAppInitializer
[2024-01-23T06:55:46.907Z]   File "/apps/superset/virtualenv/lib/python3.8/site-packages/superset/initialization/__init__.py", line 33, in <module>
[2024-01-23T06:55:46.907Z]     from superset.extensions import (
[2024-01-23T06:55:46.907Z]   File "/apps/superset/virtualenv/lib/python3.8/site-packages/superset/extensions/__init__.py", line 35, in <module>
[2024-01-23T06:55:46.907Z]     from superset.utils.machine_auth import MachineAuthProviderFactory
[2024-01-23T06:55:46.907Z]   File "/apps/superset/virtualenv/lib/python3.8/site-packages/superset/utils/machine_auth.py", line 24, in <module>
[2024-01-23T06:55:46.907Z]     from selenium.webdriver.remote.webdriver import WebDriver
[2024-01-23T06:55:46.907Z]   File "/apps/superset/virtualenv/lib/python3.8/site-packages/selenium/webdriver/__init__.py", line 29, in <module>
[2024-01-23T06:55:46.907Z]     from .firefox.firefox_profile import FirefoxProfile  # noqa
[2024-01-23T06:55:46.907Z]   File "/apps/superset/virtualenv/lib/python3.8/site-packages/selenium/webdriver/firefox/firefox_profile.py", line 31, in <module>
[2024-01-23T06:55:46.907Z]     from typing_extensions import deprecated
[2024-01-23T06:55:46.907Z] ImportError: cannot import name 'deprecated' from 'typing_extensions' (/apps/superset/virtualenv/lib/python3.8/site-packages/typing_extensions.py)

Operating System

Linux

Selenium version

Python 4.17.0

What are the browser(s) and version(s) where you see this issue?

Firefox

What are the browser driver(s) and version(s) where you see this issue?

Any

Are you using Selenium Grid?

No response

Copy link

@rpysz, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@diemol
Copy link
Member

diemol commented Jan 23, 2024

Duplicate of #13486

@diemol diemol marked this as a duplicate of #13486 Jan 23, 2024
@diemol diemol closed this as not planned Won't fix, can't repro, duplicate, stale Jan 23, 2024
@rpysz
Copy link
Author

rpysz commented Jan 23, 2024

@diemol Do you plan to release a revised version of wheel file on PyPI in the near future?

@diemol
Copy link
Member

diemol commented Jan 23, 2024

After the PR that fixes the issue is merged, I will do a release.

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants