From 07eb380981093b8bd844775f23cbd724643ac614 Mon Sep 17 00:00:00 2001 From: Alexei Barantsev Date: Sun, 27 Aug 2017 20:59:47 +0300 Subject: [PATCH] Linking ignored tests to bug reports --- .../client/test/org/openqa/selenium/ClickTest.java | 4 ++-- java/client/test/org/openqa/selenium/I18nTest.java | 1 - .../test/org/openqa/selenium/TypingTest.java | 1 - .../test/org/openqa/selenium/UploadTest.java | 2 -- .../interactions/BasicMouseInterfaceTest.java | 8 ++++---- .../interactions/CombinedInputActionsTest.java | 14 +++++++------- 6 files changed, 13 insertions(+), 17 deletions(-) diff --git a/java/client/test/org/openqa/selenium/ClickTest.java b/java/client/test/org/openqa/selenium/ClickTest.java index 16a7f5e007b3c..b8383ba44e4eb 100644 --- a/java/client/test/org/openqa/selenium/ClickTest.java +++ b/java/client/test/org/openqa/selenium/ClickTest.java @@ -261,7 +261,7 @@ public void testCanClickAnImageMapArea() { @Test @Ignore(FIREFOX) - @Ignore(MARIONETTE) + @Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/901") public void testShouldBeAbleToClickOnAnElementGreaterThanTwoViewports() { String url = appServer.whereIs("click_too_big.html"); driver.get(url); @@ -275,7 +275,7 @@ public void testShouldBeAbleToClickOnAnElementGreaterThanTwoViewports() { @SwitchToTopAfterTest @Test - @Ignore(MARIONETTE) + @Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/901") public void testShouldBeAbleToClickOnAnElementInFrameGreaterThanTwoViewports() { String url = appServer.whereIs("click_too_big_in_frame.html"); driver.get(url); diff --git a/java/client/test/org/openqa/selenium/I18nTest.java b/java/client/test/org/openqa/selenium/I18nTest.java index a49b32bec0971..90945b1597315 100644 --- a/java/client/test/org/openqa/selenium/I18nTest.java +++ b/java/client/test/org/openqa/selenium/I18nTest.java @@ -85,7 +85,6 @@ public void testEnteringHebrewTextFromRightToLeft() { } @Test - @Ignore(value = MARIONETTE, reason = "Doesn't handle first codepoint correctly.") @Ignore(value = CHROME, reason = "ChromeDriver only supports characters in the BMP") public void testEnteringSupplementaryCharacters() { assumeFalse("IE: versions less thank 10 have issue 5069", diff --git a/java/client/test/org/openqa/selenium/TypingTest.java b/java/client/test/org/openqa/selenium/TypingTest.java index c02c454615f3a..2e67f6d908a4e 100644 --- a/java/client/test/org/openqa/selenium/TypingTest.java +++ b/java/client/test/org/openqa/selenium/TypingTest.java @@ -471,7 +471,6 @@ public void testShiftSelectionDeletes() { } @Test - @Ignore(MARIONETTE) @NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/646") public void testChordControlHomeShiftEndDelete() { assumeFalse("FIXME: macs don't have HOME keys, would PGUP work?", diff --git a/java/client/test/org/openqa/selenium/UploadTest.java b/java/client/test/org/openqa/selenium/UploadTest.java index 32cec93108a80..3a7457ee45cd0 100644 --- a/java/client/test/org/openqa/selenium/UploadTest.java +++ b/java/client/test/org/openqa/selenium/UploadTest.java @@ -24,7 +24,6 @@ import static org.openqa.selenium.support.ui.ExpectedConditions.not; import static org.openqa.selenium.support.ui.ExpectedConditions.visibilityOf; import static org.openqa.selenium.testing.Driver.IE; -import static org.openqa.selenium.testing.Driver.MARIONETTE; import static org.openqa.selenium.testing.Driver.PHANTOMJS; import static org.openqa.selenium.testing.Driver.SAFARI; @@ -35,7 +34,6 @@ import org.junit.Test; import org.openqa.selenium.testing.Ignore; import org.openqa.selenium.testing.JUnit4TestBase; -import org.openqa.selenium.testing.NotYetImplemented; import org.openqa.selenium.testing.SwitchToTopAfterTest; import org.openqa.selenium.testing.TestUtilities; diff --git a/java/client/test/org/openqa/selenium/interactions/BasicMouseInterfaceTest.java b/java/client/test/org/openqa/selenium/interactions/BasicMouseInterfaceTest.java index 8fe8243ac340d..f1d38576dde20 100644 --- a/java/client/test/org/openqa/selenium/interactions/BasicMouseInterfaceTest.java +++ b/java/client/test/org/openqa/selenium/interactions/BasicMouseInterfaceTest.java @@ -372,7 +372,7 @@ public void testMovingMouseByRelativeOffset() { } @Test - @Ignore(MARIONETTE) + @Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/789") @NotYetImplemented(HTMLUNIT) public void testMovingMouseToRelativeElementOffset() { driver.get(pages.mouseTrackerPage); @@ -386,7 +386,7 @@ public void testMovingMouseToRelativeElementOffset() { } @Test - @Ignore(MARIONETTE) + @Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/789") @NotYetImplemented(HTMLUNIT) public void testMovingMouseToRelativeZeroElementOffset() { driver.get(pages.mouseTrackerPage); @@ -417,7 +417,7 @@ public void testMoveRelativeToBody() { } @Test - @Ignore(MARIONETTE) + @Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/789") @NotYetImplemented(HTMLUNIT) public void testMoveMouseByOffsetOverAndOutOfAnElement() { driver.get(pages.mouseOverPage); @@ -445,7 +445,7 @@ public void testMoveMouseByOffsetOverAndOutOfAnElement() { } @Test - @Ignore(MARIONETTE) + @Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/789") @NotYetImplemented(HTMLUNIT) public void testCanMoveOverAndOutOfAnElement() { driver.get(pages.mouseOverPage); diff --git a/java/client/test/org/openqa/selenium/interactions/CombinedInputActionsTest.java b/java/client/test/org/openqa/selenium/interactions/CombinedInputActionsTest.java index c6033f8047219..69be1e0eccf4b 100644 --- a/java/client/test/org/openqa/selenium/interactions/CombinedInputActionsTest.java +++ b/java/client/test/org/openqa/selenium/interactions/CombinedInputActionsTest.java @@ -88,7 +88,7 @@ public void testPlainClickingOnMultiSelectionList() { @Ignore(CHROME) @Ignore(IE) @Ignore(FIREFOX) - @Ignore(MARIONETTE) + @Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/646") public void testShiftClickingOnMultiSelectionList() { driver.get(pages.formSelectionPage); @@ -116,7 +116,7 @@ public void testShiftClickingOnMultiSelectionList() { @Ignore(IE) @Ignore(FIREFOX) @Ignore(PHANTOMJS) - @Ignore(MARIONETTE) + @Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/646") public void testControlClickingOnMultiSelectionList() { driver.get(pages.formSelectionPage); @@ -142,7 +142,7 @@ public void testControlClickingOnMultiSelectionList() { @Test @Ignore(IE) @Ignore(PHANTOMJS) - @Ignore(MARIONETTE) + @Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/646") public void testControlClickingOnCustomMultiSelectionList() { driver.get(pages.selectableItemsPage); @@ -226,7 +226,7 @@ public void testCanClickOnLinksWithAnOffset() { } @Test - @Ignore(MARIONETTE) + @Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/789") @NotYetImplemented(HTMLUNIT) public void testClickAfterMoveToAnElementWithAnOffsetShouldUseLastMousePosition() { driver.get(pages.clickEventPage); @@ -281,7 +281,7 @@ public void testMouseMovementWorksWhenNavigatingToAnotherPage() { } @Test - @Ignore(MARIONETTE) + @Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/646") public void testChordControlCutAndPaste() { assumeFalse("FIXME: macs don't have CONRTROL key", getEffectivePlatform().is(Platform.MAC)); assumeFalse("Windows: native events library does not support storing modifiers state yet", @@ -320,7 +320,7 @@ public void testChordControlCutAndPaste() { } @Test - @Ignore(MARIONETTE) + @Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/646") @Ignore(IE) public void testCombiningShiftAndClickResultsInANewWindow() { driver.get(pages.linkedImage); @@ -341,7 +341,7 @@ public void testCombiningShiftAndClickResultsInANewWindow() { } @Test - @Ignore(MARIONETTE) + @Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/646") @Ignore(IE) public void testHoldingDownShiftKeyWhileClicking() { driver.get(pages.clickEventPage);