Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 Feature]: Manage TLS Certificate Externally #2293

Closed
declan-fitzpatrick opened this issue Jun 28, 2024 · 3 comments · Fixed by #2306
Closed

[🚀 Feature]: Manage TLS Certificate Externally #2293

declan-fitzpatrick opened this issue Jun 28, 2024 · 3 comments · Fixed by #2306

Comments

@declan-fitzpatrick
Copy link

Feature and motivation

The tls-cert-secret.yaml has limited functionality.

It only allows self signed cert generation if ingress is enabled, and tls is disabled. Alternatively, you have to pass the values of the certificate in as non-base64 literals, which causes an issue with the selenium.jks binary.

Ideally, the helm chart would allow you to manage the secret yourself, and pass the name into a value like .Values.tls.existingSecretName. Functionally, only seleniumGrid.tls.fullname needs an update, and then tls-cert-secret.yaml would need an overall toggle

Usage example

To use the feature, you would manage your secret yourself, provisioning however you deem fit, for example:

./cert.sh
kubectl -n selenium-grid create secret generic ca-selenium --from-file=selenium.pem --from-file=selenium.jks --from-file=selenium.pkcs8

And use the TLS secret in Selenium Grid.

...
tls: 
  enabled: true
  existingSecretName: "ca-selenium"
...
Copy link

@declan-fitzpatrick, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@VietND96
Copy link
Member

In part of this, I am doing the refactoring on helm chart config keys to enable TLS ingress only or the secure connection in both server and ingress in front

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants