Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine not catching grpc exceptions cleanly #907

Closed
ukclivecox opened this issue Oct 3, 2019 · 0 comments · Fixed by #966
Closed

Engine not catching grpc exceptions cleanly #907

ukclivecox opened this issue Oct 3, 2019 · 0 comments · Fixed by #966
Assignees
Milestone

Comments

@ukclivecox
Copy link
Contributor

Add exception catches to all routes.

Like:

case MODEL:
try
{
ModelBlockingStub modelStub = ModelGrpc.newBlockingStub(grpcChannelHandler.get(endpoint))
.withDeadlineAfter(grpcReadTimeout, TimeUnit.MILLISECONDS)
.withMaxInboundMessageSize(grpcMaxMessageSize)
.withMaxOutboundMessageSize(grpcMaxMessageSize);
logger.info(modelStub.getCallOptions().toString());
return modelStub.predict(input);
}
catch (Exception e)
{
logger.error("grpc exception ",e);
throw e;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant