Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building engine on macOS #894

Closed
adriangonz opened this issue Sep 27, 2019 · 0 comments · Fixed by #895
Closed

Building engine on macOS #894

adriangonz opened this issue Sep 27, 2019 · 0 comments · Fixed by #895
Milestone

Comments

@adriangonz
Copy link
Contributor

Currently, the engine cannot be built in macOS as-is. In particular, the problem seems to lie with this line in the proto/k8s/Makefile.

sed --in-place 's|import "k8s.io/apiextensions-apiserver/|//import "k8s.io/apiextensions-apiserver/|' k8s.io/api/core/v1/generated.proto

The --in-place flag in sed doesn't work in the BSD version. Since macOS is based on BSD, the build fails at that step. Instead, we could use -i <extension> which works both on the GNU and BSD versions of sed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants