Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default values of metrics missing in /feedback API for Python wrapper #861

Closed
axsaucedo opened this issue Sep 12, 2019 · 1 comment
Closed

Comments

@axsaucedo
Copy link
Contributor

As mentioned by @jklaise in #847, 'default values of metrics were missing [for the /feedback API], i.e. if a metric has a value of 0, protobuf conversion interprets it as missing and returns the metric e.g. as {"key":"accuracy", "type": "GAUGE} when it should be {"key":"accuracy", "type": "GAUGE, "value": 0}, this will need to be fixed for the /send-feedback endpoint too for the stateful metrics.'

@ukclivecox
Copy link
Contributor

Fixed by PR- reopen if issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants