Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing MLFLOW values in crd.yaml for helm chart 0.4.0 #811

Closed
ukclivecox opened this issue Aug 20, 2019 · 3 comments · Fixed by #812
Closed

Missing MLFLOW values in crd.yaml for helm chart 0.4.0 #811

ukclivecox opened this issue Aug 20, 2019 · 3 comments · Fixed by #812
Assignees

Comments

@ukclivecox
Copy link
Contributor

Ran MLFLOW server example against 0.4.0:

The SeldonDeployment "mlflow" is invalid: []: Invalid value: map[string]interface {}{"apiVersion":"machinelearning.seldon.io/v1alpha2", "kind":"SeldonDeployment", "metadata":map[string]interface {}{"annotations":map[string]interface {}{"kubectl.kubernetes.io/last-applied-configuration":"{\"apiVersion\":\"machinelearning.seldon.io/v1alpha2\",\"kind\":\"SeldonDeployment\",\"metadata\":{\"annotations\":{},\"name\":\"mlflow\",\"namespace\":\"seldon\"},\"spec\":{\"name\":\"wines\",\"predictors\":[{\"graph\":{\"children\":[],\"implementation\":\"MLFLOW_SERVER\",\"modelUri\":\"gs://seldon-models/mlflow/elasticnet_wine\",\"name\":\"classifier\"},\"name\":\"default\",\"replicas\":1}]}}\n"}, "creationTimestamp":"2019-08-20T07:32:23Z", "generation":1, "name":"mlflow", "namespace":"seldon", "uid":"24ac6aea-44fd-47be-98a6-264ad1f68473"}, "spec":map[string]interface {}{"name":"wines", "predictors":[]interface {}{map[string]interface {}{"componentSpecs":[]interface {}{map[string]interface {}{"metadata":map[string]interface {}{"creationTimestamp":"2019-08-20T07:32:23Z"}, "spec":map[string]interface {}{"containers":[]interface {}{map[string]interface {}{"image":"seldonio/mlflowserver_rest:0.1", "name":"classifier", "resources":map[string]interface {}{}}}}}}, "graph":map[string]interface {}{"children":[]interface {}{}, "endpoint":map[string]interface {}{"service_host":"localhost", "service_port":9000, "type":"REST"}, "implementation":"MLFLOW_SERVER", "modelUri":"gs://seldon-models/mlflow/elasticnet_wine", "name":"classifier", "type":"UNKNOWN_TYPE"}, "labels":map[string]interface {}{"version":"default"}, "name":"default", "replicas":1}}}}: validation failure list:
spec.predictors.graph.implementation in body should be one of [UNKNOWN_IMPLEMENTATION SIMPLE_MODEL SIMPLE_ROUTER RANDOM_ABTEST AVERAGE_COMBINER SKLEARN_SERVER XGBOOST_SERVER TENSORFLOW_SERVER]```
@ukclivecox
Copy link
Contributor Author

We could patch the 0.4.0 chart to fix this.

@xaniasd
Copy link
Contributor

xaniasd commented Aug 27, 2019

@cliveseldon if the intention was to patch the 0.4.0 chart, it hasn't happened yet, or I'm still getting the old version.

@ukclivecox
Copy link
Contributor Author

No - yes this is only in 0.4.1-SNAPSHOT at present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants