Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seldon container engine has not resource limit #769

Closed
OrBarda opened this issue Aug 8, 2019 · 3 comments
Closed

Seldon container engine has not resource limit #769

OrBarda opened this issue Aug 8, 2019 · 3 comments
Assignees
Milestone

Comments

@OrBarda
Copy link

OrBarda commented Aug 8, 2019

Hi, the seldon-container-engine sidecar has no resource limit, thus it takes the limit from the env, which is way too much. can you please add resource limits and requests to the charts?

@ryandawsonuk
Copy link
Contributor

We have an open docs issue to make this clearer - #761 as the question has been coming up - #753 (comment)

But we do have some charts with a resources section:
https://github.com/SeldonIO/seldon-core/blob/master/helm-charts/seldon-single-model/values.yaml#L23
Which gets set in the manifest:
https://github.com/SeldonIO/seldon-core/blob/master/helm-charts/seldon-single-model/templates/model.json#L24

You could set resource limits using that chart by a --set parameter or a custom values file.

Or do you mean that you want a limit set for every deployment instead of setting it for each deployment individually?

@OrBarda
Copy link
Author

OrBarda commented Aug 18, 2019

That's exactly what I meant. It will be nice not to deal with it in every deployment.

@ukclivecox ukclivecox self-assigned this Aug 18, 2019
@ukclivecox ukclivecox added this to the 1.0.x milestone Aug 24, 2019
@ukclivecox
Copy link
Contributor

This is application specific. Will close for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants