Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put crd and controller into single helm chart #522

Closed
ryandawsonuk opened this issue Apr 24, 2019 · 3 comments
Closed

put crd and controller into single helm chart #522

ryandawsonuk opened this issue Apr 24, 2019 · 3 comments

Comments

@ryandawsonuk
Copy link
Contributor

We could have a single chart for the CRD and controller and have a crd.create option for the user to decide whether to install the CRD. This is what is done in:

https://github.com/helm/charts/blob/c7edb3f3012c4db73624583dafe6963aec3055e0/stable/sealed-secrets/values.yaml#L24

and

https://github.com/helm/charts/blob/7d0450231c4fe88483d5cb15b760a5886f3c1903/stable/prometheus-operator/values.yaml#L448

@ukclivecox
Copy link
Contributor

That's the plan for the controller rewrite in Golang. A single helm chart with both and then allow people to add ingress as needed : Ambassador, Seldon OAuth Gateway, Istio-Ingress.

@ryandawsonuk
Copy link
Contributor Author

This will be closed out by #559

@ukclivecox
Copy link
Contributor

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants