You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
An earlier PR (#3203) increased the verbosity that rclone logs with, which, in turns happens to also log sensitive values like S3 secret key configured via environment variables:
2022/08/01 17:27:54 DEBUG : Setting access_key_id="<sensitive value>" for "s3" from environment variable RCLONE_CONFIG_S3_ACCESS_KEY_ID
2022/08/01 17:27:54 DEBUG : Setting secret_access_key="<sensitive value>" for "s3" from environment variable RCLONE_CONFIG_S3_SECRET_ACCESS_KEY
Would it be possible to make the verbosity configurable and verbosity level 1 (-v) by default? The verbosity can also be configured with RCLONE_VERBOSE=(0|1|2), but, since the argument -vv is explicitly passed in the Dockerfile, this gets ignored. I currently can't figure out a workaround for this while I wait for a fix.
To reproduce
Configure Seldon Core to use AWS S3 secrets from a Secret resource that specifies RCLONE_CONFIG_S3_... config values
Deploy a model that references this AWS S3 secret
Check the logs for the initializer container (in my case it was a tensorflow model, so the container was tfserving-model-initializer)
Expected behaviour
By default, logs don't log DEBUG messages, which may expose sensitive values, but, verbosity is configurable if needed for debugging
Environment
Cloud Provider: GKE
Kubernetes Cluster Version [Output of kubectl version]
Describe the bug
An earlier PR (#3203) increased the verbosity that rclone logs with, which, in turns happens to also log sensitive values like S3 secret key configured via environment variables:
Would it be possible to make the verbosity configurable and verbosity level 1 (
-v
) by default? The verbosity can also be configured withRCLONE_VERBOSE=(0|1|2)
, but, since the argument-vv
is explicitly passed in the Dockerfile, this gets ignored. I currently can't figure out a workaround for this while I wait for a fix.To reproduce
RCLONE_CONFIG_S3_...
config valuestfserving-model-initializer
)Expected behaviour
By default, logs don't log DEBUG messages, which may expose sensitive values, but, verbosity is configurable if needed for debugging
Environment
kubectl version
]kubectl get --namespace seldon-system deploy seldon-controller-manager -o yaml | grep seldonio
]Model Details
Tensorflow model from a private repo
The text was updated successfully, but these errors were encountered: