Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support using SSL with PEM strings #3867

Closed
stephen37 opened this issue Jan 18, 2022 · 0 comments · Fixed by #3868
Closed

Support using SSL with PEM strings #3867

stephen37 opened this issue Jan 18, 2022 · 0 comments · Fixed by #3868
Labels

Comments

@stephen37
Copy link
Contributor

stephen37 commented Jan 18, 2022

Describe the bug

It is not possible to add CA certificate by PEM string when using SSL with Kafka when using the configuration ssl.ca.pem. This is because it has been added in the version v1.8.2 of librdkafka which has been released in October 2021.
The executor is using the version v1.4.2 which has been released in May 2020.

To reproduce

Try to define ssl.ca.pem in the ConfigMap used by Kafka, e.g.

kafkaConfig: kafka.ConfigMap{
    "security.protocol":   "SSL",
    "ssl.ca.pem":          caPEM,
    "ssl.key.pem":         keyPEM,
    "ssl.certificate.pem": certPEM,
    "ssl.key.password":    keyPassword,
},

it will result in an error saying "No such configuration property: "ssl.ca.pem\",. You can make it crash easily by changing the worker_test.go configuration https://github.com/SeldonIO/seldon-core/blob/master/executor/logger/worker_test.go#L140-L146

Expected behaviour

It should be possible to define that option in the configuration, it is defined in librdkafka which is what confluent-kafka-go is using behind the scene.

We have to wait for this issue to be addressed until we can make that possible: #3866

PR to solve this issue: #3868

@stephen37 stephen37 added the bug label Jan 18, 2022
@stephen37 stephen37 changed the title Support Definition of CA Certificate by PEM String Support using SSL with PEM strings Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant