Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seldon Batch Template Bug? #2943

Closed
snowneji opened this issue Feb 10, 2021 · 1 comment · Fixed by #3008
Closed

Seldon Batch Template Bug? #2943

snowneji opened this issue Feb 10, 2021 · 1 comment · Fixed by #3008
Assignees
@RafalSkolasinski
Labels
bug priority/p2

Comments

@snowneji
Copy link

snowneji commented Feb 10, 2021 •
edited
Loading

Describe the bug

I'm using the helm template here to experiment a batch processing pipeline with Seldoncore.

In this file: https://github.com/SeldonIO/seldon-core/blob/master/examples/batch/argo-workflows-batch/helm-charts/seldon-batch-workflow/templates/workflow.yaml, line 69-70, shouldn't containers be under spec instead of in a list at the same level?

Also locally I'm getting this error using the helm template which possibly confirms the issue, so I guess the hierarchy issue cause the error?

The SeldonDeployment "seldon-7ceba0fc-4fd9-416f-8d92-46ed3e577f62" is invalid: spec.predictors.componentSpecs.spec: Invalid value: "null": spec.predictors.componentSpecs.spec in body must be of type object: "null"
@snowneji snowneji added bug triage Needs to be triaged and prioritised accordingly labels Feb 10, 2021
@ukclivecox ukclivecox removed the triage Needs to be triaged and prioritised accordingly label Feb 11, 2021
@RafalSkolasinski
Copy link
Contributor

RafalSkolasinski commented Feb 25, 2021 •
edited
Loading

Hi @snowneji, what version of:

  • helm
  • SC
  • kubernetes

do you run?

@RafalSkolasinski RafalSkolasinski mentioned this issue Mar 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RafalSkolasinski RafalSkolasinski

Labels
bug priority/p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix indentation of argo batch template
3 participants
@ukclivecox @snowneji @RafalSkolasinski